From 63bc7c39a52a3de9c578bbfbe42c0076f6a748c0 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Thu, 30 Mar 2017 22:06:49 +0100 Subject: Fix type parameter capture --- .../couscous/frontends/java/GeneratedClosure.java | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) (limited to 'src/main/java/org/zwobble/couscous/frontends') diff --git a/src/main/java/org/zwobble/couscous/frontends/java/GeneratedClosure.java b/src/main/java/org/zwobble/couscous/frontends/java/GeneratedClosure.java index 0bf7649..9e0e4bb 100644 --- a/src/main/java/org/zwobble/couscous/frontends/java/GeneratedClosure.java +++ b/src/main/java/org/zwobble/couscous/frontends/java/GeneratedClosure.java @@ -1,27 +1,22 @@ package org.zwobble.couscous.frontends.java; -import com.google.common.collect.ImmutableList; import org.zwobble.couscous.ast.ClassNode; import org.zwobble.couscous.ast.ConstructorCallNode; import org.zwobble.couscous.ast.ExpressionNode; import org.zwobble.couscous.ast.ReferenceNode; import org.zwobble.couscous.types.ScalarType; -import org.zwobble.couscous.types.TypeParameter; import org.zwobble.couscous.util.InsertionOrderSet; import static org.zwobble.couscous.ast.ConstructorCallNode.constructorCall; import static org.zwobble.couscous.types.Types.addTypeParameters; -import static org.zwobble.couscous.util.ExtraLists.concat; -import static org.zwobble.couscous.util.ExtraLists.list; +import static org.zwobble.couscous.util.ExtraLists.*; public class GeneratedClosure { private final ClassNode classNode; - private final InsertionOrderSet capturedTypes; private final InsertionOrderSet capturedVariables; - public GeneratedClosure(ClassNode classNode, InsertionOrderSet capturedTypes, InsertionOrderSet capturedVariables) { + public GeneratedClosure(ClassNode classNode, InsertionOrderSet capturedVariables) { this.classNode = classNode; - this.capturedTypes = capturedTypes; this.capturedVariables = capturedVariables; } @@ -36,19 +31,15 @@ public class GeneratedClosure { public ConstructorCallNode generateConstructor(Iterable arguments) { return constructorCall( // TODO: tidy up type parameters to avoid copy - addTypeParameters(getType(), ImmutableList.copyOf(capturedTypes.asList())), + addTypeParameters(getType(), eagerMap(classNode.getTypeParameters(), parameter -> parameter.getType())), concat(capturedVariables, arguments)); } public boolean hasCaptures() { - return !capturedTypes.isEmpty() || !capturedVariables.isEmpty(); + return !capturedVariables.isEmpty(); } private ScalarType getType() { return classNode.getName(); } - - public InsertionOrderSet getCapturedTypes() { - return capturedTypes; - } } -- cgit v1.2.3