From e5f70950620f2178fefe91f33a3401f831f32e7d Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Sun, 14 Feb 2016 19:31:02 +0000 Subject: Strip empty nodes from output --- src/main/java/org/zwobble/mammoth/html/Html.java | 43 ++++++++++++++++++++++ .../java/org/zwobble/mammoth/html/HtmlElement.java | 9 +++++ .../org/zwobble/mammoth/html/HtmlForceWrite.java | 5 +++ .../java/org/zwobble/mammoth/html/HtmlNode.java | 9 +++++ .../mammoth/html/HtmlSelfClosingElement.java | 5 +++ .../org/zwobble/mammoth/html/HtmlTextNode.java | 5 +++ 6 files changed, 76 insertions(+) (limited to 'src/main/java/org/zwobble/mammoth/html') diff --git a/src/main/java/org/zwobble/mammoth/html/Html.java b/src/main/java/org/zwobble/mammoth/html/Html.java index 0a32e58..7e2a82e 100644 --- a/src/main/java/org/zwobble/mammoth/html/Html.java +++ b/src/main/java/org/zwobble/mammoth/html/Html.java @@ -1,5 +1,7 @@ package org.zwobble.mammoth.html; +import org.zwobble.mammoth.util.MammothLists; + import java.util.List; import java.util.Map; @@ -50,4 +52,45 @@ public class Html { public static HtmlNode selfClosingElement(String tagName, Map attributes) { return new HtmlSelfClosingElement(tagName, attributes); } + + public static List stripEmpty(List nodes) { + return MammothLists.eagerFlatMap(nodes, node -> stripEmpty(node)); + } + + private static List stripEmpty(HtmlNode node) { + return node.accept(new HtmlNode.Mapper>() { + @Override + public List visit(HtmlElement element) { + List children = stripEmpty(element.getChildren()); + if (children.isEmpty()) { + return list(); + } else { + return list(new HtmlElement( + element.getTagName(), + element.getAttributes(), + children, + element.isCollapsible())); + } + } + + @Override + public List visit(HtmlSelfClosingElement element) { + return list(element); + } + + @Override + public List visit(HtmlTextNode node) { + if (node.getValue().isEmpty()) { + return list(); + } else { + return list(node); + } + } + + @Override + public List visit(HtmlForceWrite forceWrite) { + return list(forceWrite); + } + }); + } } diff --git a/src/main/java/org/zwobble/mammoth/html/HtmlElement.java b/src/main/java/org/zwobble/mammoth/html/HtmlElement.java index 59683ba..cc81aa2 100644 --- a/src/main/java/org/zwobble/mammoth/html/HtmlElement.java +++ b/src/main/java/org/zwobble/mammoth/html/HtmlElement.java @@ -28,8 +28,17 @@ public class HtmlElement implements HtmlNode { return children; } + public boolean isCollapsible() { + return collapsible; + } + @Override public void visit(Visitor visitor) { visitor.visit(this); } + + @Override + public T accept(Mapper visitor) { + return visitor.visit(this); + } } diff --git a/src/main/java/org/zwobble/mammoth/html/HtmlForceWrite.java b/src/main/java/org/zwobble/mammoth/html/HtmlForceWrite.java index 484be34..f704fd9 100644 --- a/src/main/java/org/zwobble/mammoth/html/HtmlForceWrite.java +++ b/src/main/java/org/zwobble/mammoth/html/HtmlForceWrite.java @@ -10,4 +10,9 @@ public class HtmlForceWrite implements HtmlNode { public void visit(Visitor visitor) { visitor.visit(this); } + + @Override + public T accept(Mapper visitor) { + return visitor.visit(this); + } } diff --git a/src/main/java/org/zwobble/mammoth/html/HtmlNode.java b/src/main/java/org/zwobble/mammoth/html/HtmlNode.java index 823e362..6099519 100644 --- a/src/main/java/org/zwobble/mammoth/html/HtmlNode.java +++ b/src/main/java/org/zwobble/mammoth/html/HtmlNode.java @@ -1,7 +1,9 @@ package org.zwobble.mammoth.html; public interface HtmlNode { + // TODO: rename visit to accept void visit(Visitor visitor); + T accept(Mapper visitor); interface Visitor { void visit(HtmlElement element); @@ -9,4 +11,11 @@ public interface HtmlNode { void visit(HtmlTextNode node); void visit(HtmlForceWrite forceWrite); } + + interface Mapper { + T visit(HtmlElement element); + T visit(HtmlSelfClosingElement element); + T visit(HtmlTextNode node); + T visit(HtmlForceWrite forceWrite); + } } diff --git a/src/main/java/org/zwobble/mammoth/html/HtmlSelfClosingElement.java b/src/main/java/org/zwobble/mammoth/html/HtmlSelfClosingElement.java index a1ddf2b..62bfd73 100644 --- a/src/main/java/org/zwobble/mammoth/html/HtmlSelfClosingElement.java +++ b/src/main/java/org/zwobble/mammoth/html/HtmlSelfClosingElement.java @@ -23,4 +23,9 @@ public class HtmlSelfClosingElement implements HtmlNode { public void visit(Visitor visitor) { visitor.visit(this); } + + @Override + public T accept(Mapper visitor) { + return visitor.visit(this); + } } diff --git a/src/main/java/org/zwobble/mammoth/html/HtmlTextNode.java b/src/main/java/org/zwobble/mammoth/html/HtmlTextNode.java index 37dceec..a9f9fd5 100644 --- a/src/main/java/org/zwobble/mammoth/html/HtmlTextNode.java +++ b/src/main/java/org/zwobble/mammoth/html/HtmlTextNode.java @@ -15,4 +15,9 @@ public class HtmlTextNode implements HtmlNode { public void visit(Visitor visitor) { visitor.visit(this); } + + @Override + public T accept(Mapper visitor) { + return visitor.visit(this); + } } -- cgit v1.2.3