From 2b5635c1425f7a4e31d2d0aedb892f2d8d033f92 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Sun, 3 Aug 2025 09:36:04 +0100 Subject: Remove type argument from HasChildren --- .../internal/conversion/DocumentToHtml.java | 35 +++++++++++----------- 1 file changed, 18 insertions(+), 17 deletions(-) (limited to 'src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java') diff --git a/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java b/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java index 6186cdb..dbbe3c3 100644 --- a/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java +++ b/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java @@ -81,22 +81,6 @@ public class DocumentToHtml { this.comments = Maps.toMapWithKey(comments, Comment::getCommentId); } - private List convertToHtml(Document document, Context context) { - List mainBody = convertChildrenToHtml(document, context); - // TODO: can you have note references inside a note? - List notes = findNotes(document, noteReferences); - - List noteNodes = notes.isEmpty() - ? list() - : list(Html.element("ol", eagerMap(notes, note -> convertToHtml(note, context)))); - - List commentNodes = referencedComments.isEmpty() - ? list() - : list(Html.element("dl", eagerFlatMap(referencedComments, comment -> convertToHtml(comment, context)))); - - return eagerConcat(mainBody, noteNodes, commentNodes); - } - private HtmlNode convertToHtml(Note note, Context context) { String id = generateNoteHtmlId(note.getNoteType(), note.getId()); String referenceId = generateNoteRefHtmlId(note.getNoteType(), note.getId()); @@ -135,11 +119,28 @@ public class DocumentToHtml { ); } - private List convertChildrenToHtml(HasChildren element, Context context) { + private List convertChildrenToHtml(HasChildren element, Context context) { return convertToHtml(element.getChildren(), context); } private class ElementConverterVisitor implements DocumentElementVisitor, Context> { + @Override + public List visit(Document document, Context context) { + List mainBody = convertChildrenToHtml(document, context); + // TODO: can you have note references inside a note? + List notes = findNotes(document, noteReferences); + + List noteNodes = notes.isEmpty() + ? list() + : list(Html.element("ol", eagerMap(notes, note -> convertToHtml(note, context)))); + + List commentNodes = referencedComments.isEmpty() + ? list() + : list(Html.element("dl", eagerFlatMap(referencedComments, comment -> convertToHtml(comment, context)))); + + return eagerConcat(mainBody, noteNodes, commentNodes); + } + @Override public List visit(Paragraph paragraph, Context context) { Supplier> children = () -> { -- cgit v1.2.3