From 93e92326208e3a374c170beeb323578fedf0d337 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Sun, 28 Aug 2016 23:11:57 +0100 Subject: Defer generation of child nodes until necessary --- .../mammoth/internal/conversion/DocumentToHtml.java | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) (limited to 'src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java') diff --git a/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java b/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java index 1eb66d3..1254747 100644 --- a/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java +++ b/src/main/java/org/zwobble/mammoth/internal/conversion/DocumentToHtml.java @@ -11,6 +11,7 @@ import org.zwobble.mammoth.internal.util.Lists; import java.io.IOException; import java.util.*; +import java.util.function.Supplier; import static org.zwobble.mammoth.internal.util.Lists.*; import static org.zwobble.mammoth.internal.util.Maps.map; @@ -89,8 +90,10 @@ public class DocumentToHtml { return element.accept(new DocumentElementVisitor>() { @Override public List visit(Paragraph paragraph) { - List content = convertChildrenToHtml(paragraph); - List children = preserveEmptyParagraphs ? cons(Html.FORCE_WRITE, content) : content; + Supplier> children = () -> { + List content = convertChildrenToHtml(paragraph); + return preserveEmptyParagraphs ? cons(Html.FORCE_WRITE, content) : content; + }; HtmlPath mapping = styleMap.getParagraphHtmlPath(paragraph) .orElseGet(() -> { if (paragraph.getStyle().isPresent()) { @@ -98,12 +101,12 @@ public class DocumentToHtml { } return HtmlPath.element("p"); }); - return mapping.wrap(children); + return mapping.wrap(children).get(); } @Override public List visit(Run run) { - List nodes = convertChildrenToHtml(run); + Supplier> nodes = () -> convertChildrenToHtml(run); if (run.isStrikethrough()) { nodes = styleMap.getStrikethrough().orElse(HtmlPath.collapsibleElement("s")).wrap(nodes); } @@ -111,10 +114,10 @@ public class DocumentToHtml { nodes = styleMap.getUnderline().orElse(HtmlPath.EMPTY).wrap(nodes); } if (run.getVerticalAlignment() == VerticalAlignment.SUBSCRIPT) { - nodes = list(Html.collapsibleElement("sub", nodes)); + nodes = HtmlPath.collapsibleElement("sub").wrap(nodes); } if (run.getVerticalAlignment() == VerticalAlignment.SUPERSCRIPT) { - nodes = list(Html.collapsibleElement("sup", nodes)); + nodes = HtmlPath.collapsibleElement("sup").wrap(nodes); } if (run.isItalic()) { nodes = styleMap.getItalic().orElse(HtmlPath.collapsibleElement("em")).wrap(nodes); @@ -129,7 +132,7 @@ public class DocumentToHtml { } return HtmlPath.EMPTY; }); - return mapping.wrap(nodes); + return mapping.wrap(nodes).get(); } @Override -- cgit v1.2.3