From 1d724603e22e8941b0813b89bcdf106d95862ec4 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Fri, 17 Jun 2016 21:46:54 +0100 Subject: Replace for loop with map --- .../org/zwobble/mammoth/internal/docx/BodyXmlReader.java | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java') diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java index b4929fa..81e0307 100644 --- a/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java +++ b/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java @@ -16,6 +16,7 @@ import java.util.function.Function; import static org.zwobble.mammoth.internal.docx.ReadResult.EMPTY_SUCCESS; import static org.zwobble.mammoth.internal.docx.ReadResult.success; import static org.zwobble.mammoth.internal.util.Iterables.lazyFilter; +import static org.zwobble.mammoth.internal.util.Lists.eagerMap; import static org.zwobble.mammoth.internal.util.Lists.list; import static org.zwobble.mammoth.internal.util.Maps.entry; import static org.zwobble.mammoth.internal.util.Maps.lookup; @@ -267,9 +268,8 @@ public class BodyXmlReader { } } - List mergedRows = new ArrayList<>(); - for (int rowIndex = 0; rowIndex < rows.size(); rowIndex += 1) { - TableRow row = (TableRow) rows.get(rowIndex); + return success(eagerMap(rows, (rowIndex, rowElement) -> { + TableRow row = (TableRow) rowElement; List mergedCells = new ArrayList<>(); for (int cellIndex = 0; cellIndex < row.getChildren().size(); cellIndex += 1) { @@ -283,10 +283,9 @@ public class BodyXmlReader { )); } } - - mergedRows.add(new TableRow(mergedCells)); - } - return success(mergedRows); + + return new TableRow(mergedCells); + })); } private Optional checkTableRows(List rows) { -- cgit v1.2.3