From 250c8850c4f7e0b2db5146683392fc20485b9339 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Wed, 16 Nov 2016 20:45:00 +0000 Subject: Introduce HtmlTag class --- .../org/zwobble/mammoth/internal/html/Html.java | 17 ++++------- .../zwobble/mammoth/internal/html/HtmlElement.java | 22 +++++++------- .../org/zwobble/mammoth/internal/html/HtmlTag.java | 34 ++++++++++++++++++++++ 3 files changed, 51 insertions(+), 22 deletions(-) create mode 100644 src/main/java/org/zwobble/mammoth/internal/html/HtmlTag.java (limited to 'src/main/java/org/zwobble/mammoth/internal/html') diff --git a/src/main/java/org/zwobble/mammoth/internal/html/Html.java b/src/main/java/org/zwobble/mammoth/internal/html/Html.java index f0a01dd..4c7a9a9 100644 --- a/src/main/java/org/zwobble/mammoth/internal/html/Html.java +++ b/src/main/java/org/zwobble/mammoth/internal/html/Html.java @@ -38,7 +38,7 @@ public class Html { } public static HtmlNode element(String tagName, Map attributes, List children) { - return new HtmlElement(list(tagName), attributes, children, false); + return new HtmlElement(new HtmlTag(list(tagName), attributes, false, ""), children); } public static HtmlNode collapsibleElement(String tagName) { @@ -58,7 +58,7 @@ public class Html { } public static HtmlNode collapsibleElement(List tagNames, Map attributes, List children) { - return new HtmlElement(tagNames, attributes, children, true); + return new HtmlElement(new HtmlTag(tagNames, attributes, true, ""), children); } public static HtmlNode selfClosingElement(String tagName) { @@ -81,11 +81,7 @@ public class Html { if (children.isEmpty()) { return list(); } else { - return list(new HtmlElement( - element.getTagNames(), - element.getAttributes(), - children, - element.isCollapsible())); + return list(new HtmlElement(element.getTag(), children)); } } @@ -132,10 +128,9 @@ public class Html { @Override public HtmlNode visit(HtmlElement element) { return new HtmlElement( - element.getTagNames(), - element.getAttributes(), - collapse(element.getChildren()), - element.isCollapsible()); + element.getTag(), + collapse(element.getChildren()) + ); } @Override diff --git a/src/main/java/org/zwobble/mammoth/internal/html/HtmlElement.java b/src/main/java/org/zwobble/mammoth/internal/html/HtmlElement.java index e855f26..9999fbc 100644 --- a/src/main/java/org/zwobble/mammoth/internal/html/HtmlElement.java +++ b/src/main/java/org/zwobble/mammoth/internal/html/HtmlElement.java @@ -4,28 +4,28 @@ import java.util.List; import java.util.Map; public class HtmlElement implements HtmlNode { - private final List tagNames; - private final Map attributes; + private final HtmlTag tag; private final List children; - private final boolean collapsible; - public HtmlElement(List tagNames, Map attributes, List children, boolean collapsible) { - this.tagNames = tagNames; - this.attributes = attributes; + public HtmlElement(HtmlTag tag, List children) { + this.tag = tag; this.children = children; - this.collapsible = collapsible; + } + + public HtmlTag getTag() { + return tag; } public List getTagNames() { - return tagNames; + return tag.getTagNames(); } public String getTagName() { - return tagNames.get(0); + return getTagNames().get(0); } public Map getAttributes() { - return attributes; + return tag.getAttributes(); } public List getChildren() { @@ -33,7 +33,7 @@ public class HtmlElement implements HtmlNode { } public boolean isCollapsible() { - return collapsible; + return tag.isCollapsible(); } @Override diff --git a/src/main/java/org/zwobble/mammoth/internal/html/HtmlTag.java b/src/main/java/org/zwobble/mammoth/internal/html/HtmlTag.java new file mode 100644 index 0000000..ea42206 --- /dev/null +++ b/src/main/java/org/zwobble/mammoth/internal/html/HtmlTag.java @@ -0,0 +1,34 @@ +package org.zwobble.mammoth.internal.html; + +import java.util.List; +import java.util.Map; + +public class HtmlTag { + private final List tagNames; + private final Map attributes; + private final boolean isCollapsible; + private final String separator; + + public HtmlTag(List tagNames, Map attributes, boolean isCollapsible, String separator) { + this.tagNames = tagNames; + this.attributes = attributes; + this.isCollapsible = isCollapsible; + this.separator = separator; + } + + public List getTagNames() { + return tagNames; + } + + public Map getAttributes() { + return attributes; + } + + public boolean isCollapsible() { + return isCollapsible; + } + + public String getSeparator() { + return separator; + } +} -- cgit v1.2.3