From 5ae9816b2dcfd2d23d627758fe7e43f6193769dc Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Sat, 13 Feb 2016 17:52:44 +0000 Subject: Extract MammothOptionals.flatMap --- .../java/org/zwobble/mammoth/docx/BodyXmlReader.java | 12 +++++------- .../org/zwobble/mammoth/util/MammothOptionals.java | 18 ++++++++++++++++++ 2 files changed, 23 insertions(+), 7 deletions(-) create mode 100644 src/main/java/org/zwobble/mammoth/util/MammothOptionals.java (limited to 'src/main') diff --git a/src/main/java/org/zwobble/mammoth/docx/BodyXmlReader.java b/src/main/java/org/zwobble/mammoth/docx/BodyXmlReader.java index 7a235a2..334f925 100644 --- a/src/main/java/org/zwobble/mammoth/docx/BodyXmlReader.java +++ b/src/main/java/org/zwobble/mammoth/docx/BodyXmlReader.java @@ -2,6 +2,7 @@ package org.zwobble.mammoth.docx; import com.google.common.collect.ImmutableList; import org.zwobble.mammoth.documents.*; +import org.zwobble.mammoth.util.MammothOptionals; import org.zwobble.mammoth.xml.XmlElement; import org.zwobble.mammoth.xml.XmlElementLike; import org.zwobble.mammoth.xml.XmlNode; @@ -63,13 +64,10 @@ public class BodyXmlReader { private Optional readNumbering(XmlElementLike properties) { XmlElementLike numberingProperties = properties.findChildOrEmpty("w:numPr"); - Optional numId = readVal(numberingProperties, "w:numId"); - Optional levelIndex = readVal(numberingProperties, "w:ilvl"); - if (numId.isPresent() && levelIndex.isPresent()) { - return numbering.findLevel(numId.get(), levelIndex.get()); - } else { - return Optional.empty(); - } + return MammothOptionals.flatMap( + readVal(numberingProperties, "w:numId"), + readVal(numberingProperties, "w:ilvl"), + numbering::findLevel); } private Optional readVal(XmlElementLike element, String name) { diff --git a/src/main/java/org/zwobble/mammoth/util/MammothOptionals.java b/src/main/java/org/zwobble/mammoth/util/MammothOptionals.java new file mode 100644 index 0000000..e0e4876 --- /dev/null +++ b/src/main/java/org/zwobble/mammoth/util/MammothOptionals.java @@ -0,0 +1,18 @@ +package org.zwobble.mammoth.util; + +import java.util.Optional; +import java.util.function.BiFunction; + +public class MammothOptionals { + public static Optional flatMap( + Optional first, + Optional second, + BiFunction> function) + { + if (first.isPresent() && second.isPresent()) { + return function.apply(first.get(), second.get()); + } else { + return Optional.empty(); + } + } +} -- cgit v1.2.3