From 955a29e828d40123ec64a479b1c4c5164db3c681 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Mon, 29 Aug 2016 11:37:27 +0100 Subject: Wire up comment conversion code --- .../zwobble/mammoth/internal/docx/BodyXmlReader.java | 1 + .../zwobble/mammoth/internal/docx/DocumentReader.java | 16 +++++++++++++--- .../mammoth/internal/docx/DocumentXmlReader.java | 9 ++++++--- .../mammoth/internal/results/InternalResult.java | 11 +++++++++++ .../zwobble/mammoth/internal/styles/DefaultStyles.java | 2 ++ .../java/org/zwobble/mammoth/tests/MammothTests.java | 13 +++++++++++++ .../org/zwobble/mammoth/tests/docx/BodyXmlTests.java | 1 + .../zwobble/mammoth/tests/docx/DocumentXmlTests.java | 4 ++-- src/test/resources/test-data/comments.docx | Bin 0 -> 15526 bytes 9 files changed, 49 insertions(+), 8 deletions(-) create mode 100755 src/test/resources/test-data/comments.docx (limited to 'src') diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java index 6dd1134..0c514fb 100644 --- a/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java +++ b/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java @@ -116,6 +116,7 @@ public class BodyXmlReader { case "w:del": case "w:footnoteRef": case "w:endnoteRef": + case "w:annotationRef": case "w:pPr": case "w:rPr": case "w:tblPr": diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/DocumentReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/DocumentReader.java index b53c9dd..0452c63 100644 --- a/src/main/java/org/zwobble/mammoth/internal/docx/DocumentReader.java +++ b/src/main/java/org/zwobble/mammoth/internal/docx/DocumentReader.java @@ -1,5 +1,6 @@ package org.zwobble.mammoth.internal.docx; +import org.zwobble.mammoth.internal.documents.Comment; import org.zwobble.mammoth.internal.documents.Document; import org.zwobble.mammoth.internal.documents.Notes; import org.zwobble.mammoth.internal.results.InternalResult; @@ -9,6 +10,7 @@ import org.zwobble.mammoth.internal.xml.XmlElement; import java.io.IOException; import java.nio.file.Path; +import java.util.List; import java.util.Optional; import static org.zwobble.mammoth.internal.util.Lists.list; @@ -28,13 +30,21 @@ public class DocumentReader { Relationships relationships = readRelationships(zipFile, name); return new BodyXmlReader(styles, numbering, relationships, contentTypes, zipFile, fileReader); }; - return readNotes(zipFile, bodyReaders) - .flatMap(notes -> { - DocumentXmlReader reader = new DocumentXmlReader(bodyReaders.forName("document"), notes); + return InternalResult.flatMap( + readNotes(zipFile, bodyReaders), + readComments(zipFile, bodyReaders), + (notes, comments) -> { + DocumentXmlReader reader = new DocumentXmlReader(bodyReaders.forName("document"), notes, comments); return reader.readElement(parseOfficeXml(zipFile, "word/document.xml")); }); } + private static InternalResult> readComments(DocxFile file, BodyReaders bodyReaders) { + return tryParseOfficeXml(file, "word/comments.xml") + .map(new CommentXmlReader(bodyReaders.forName("comments"))::readElement) + .orElse(InternalResult.success(list())); + } + private static InternalResult readNotes(DocxFile file, BodyReaders bodyReaders) { return InternalResult.map( tryParseOfficeXml(file, "word/footnotes.xml") diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/DocumentXmlReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/DocumentXmlReader.java index bd7247e..25855f3 100644 --- a/src/main/java/org/zwobble/mammoth/internal/docx/DocumentXmlReader.java +++ b/src/main/java/org/zwobble/mammoth/internal/docx/DocumentXmlReader.java @@ -1,26 +1,29 @@ package org.zwobble.mammoth.internal.docx; +import org.zwobble.mammoth.internal.documents.Comment; import org.zwobble.mammoth.internal.documents.Document; import org.zwobble.mammoth.internal.documents.Notes; import org.zwobble.mammoth.internal.results.InternalResult; import org.zwobble.mammoth.internal.xml.XmlElement; import org.zwobble.mammoth.internal.xml.XmlElementLike; -import static org.zwobble.mammoth.internal.util.Lists.list; +import java.util.List; public class DocumentXmlReader { private final BodyXmlReader bodyReader; private final Notes notes; + private final List comments; - public DocumentXmlReader(BodyXmlReader bodyReader, Notes notes) { + public DocumentXmlReader(BodyXmlReader bodyReader, Notes notes, List comments) { this.bodyReader = bodyReader; this.notes = notes; + this.comments = comments; } public InternalResult readElement(XmlElement element) { XmlElementLike body = element.findChildOrEmpty("w:body"); return bodyReader.readElements(body.getChildren()) .toResult() - .map(children -> new Document(children, notes, list())); + .map(children -> new Document(children, notes, comments)); } } diff --git a/src/main/java/org/zwobble/mammoth/internal/results/InternalResult.java b/src/main/java/org/zwobble/mammoth/internal/results/InternalResult.java index b2e892b..d18f278 100644 --- a/src/main/java/org/zwobble/mammoth/internal/results/InternalResult.java +++ b/src/main/java/org/zwobble/mammoth/internal/results/InternalResult.java @@ -23,6 +23,17 @@ public class InternalResult { lazyFlatMap(results, result -> result.warnings)); } + public static InternalResult flatMap( + InternalResult first, + InternalResult second, + BiFunction> function) + { + InternalResult intermediateResult = function.apply(first.value, second.value); + return new InternalResult<>( + intermediateResult.value, + lazyConcat(lazyConcat(first.warnings, second.warnings), intermediateResult.warnings)); + } + public static InternalResult map( InternalResult first, InternalResult second, diff --git a/src/main/java/org/zwobble/mammoth/internal/styles/DefaultStyles.java b/src/main/java/org/zwobble/mammoth/internal/styles/DefaultStyles.java index 3aaf655..c9c5b5b 100644 --- a/src/main/java/org/zwobble/mammoth/internal/styles/DefaultStyles.java +++ b/src/main/java/org/zwobble/mammoth/internal/styles/DefaultStyles.java @@ -26,6 +26,8 @@ public class DefaultStyles { "r[style-name='footnote reference'] =>", "p[style-name='endnote text'] => p", "r[style-name='endnote reference'] =>", + "p[style-name='annotation text'] => p", + "r[style-name='annotation reference'] =>", // LibreOffice "p[style-name='Footnote'] => p", diff --git a/src/test/java/org/zwobble/mammoth/tests/MammothTests.java b/src/test/java/org/zwobble/mammoth/tests/MammothTests.java index 455fa0c..fff4cb3 100644 --- a/src/test/java/org/zwobble/mammoth/tests/MammothTests.java +++ b/src/test/java/org/zwobble/mammoth/tests/MammothTests.java @@ -154,6 +154,19 @@ public class MammothTests { "
  • Fin. ↑

  • ")); } + @Test + public void whenStyleMappingIsDefinedForCommentReferencesThenCommentsAreIncluded() throws IOException { + assertThat( + convertToHtml("comments.docx", mammoth -> mammoth.idPrefix("doc-42-").addStyleMap("comment-reference => sup")), + isSuccess( + "

    Ouch" + + "[MW1]." + + "[MW2]

    " + + "
    Comment [MW1]

    A tachyon walks into a bar. ↑

    " + + "
    Comment [MW2]

    Fin. ↑

    " + )); + } + @Test public void relationshipsAreReadForEachFileContainingBodyXml() throws IOException { assertThat( diff --git a/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java b/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java index 3a0da26..f59bf58 100644 --- a/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java +++ b/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java @@ -704,6 +704,7 @@ public class BodyXmlTests { assertIsIgnored("w:del"); assertIsIgnored("w:footnoteRef"); assertIsIgnored("w:endnoteRef"); + assertIsIgnored("w:annotationRef"); assertIsIgnored("w:pPr"); assertIsIgnored("w:rPr"); assertIsIgnored("w:tblPr"); diff --git a/src/test/java/org/zwobble/mammoth/tests/docx/DocumentXmlTests.java b/src/test/java/org/zwobble/mammoth/tests/docx/DocumentXmlTests.java index 9697c6d..19f1a95 100644 --- a/src/test/java/org/zwobble/mammoth/tests/docx/DocumentXmlTests.java +++ b/src/test/java/org/zwobble/mammoth/tests/docx/DocumentXmlTests.java @@ -31,7 +31,7 @@ public class DocumentXmlTests { element("w:t", list( XmlNodes.text("Hello!"))))))))))); - DocumentXmlReader reader = new DocumentXmlReader(bodyReader(), Notes.EMPTY); + DocumentXmlReader reader = new DocumentXmlReader(bodyReader(), Notes.EMPTY, list()); assertThat( reader.readElement(documentElement), @@ -45,7 +45,7 @@ public class DocumentXmlTests { public void notesOfDocumentAreIncludedInDocument() { Note note = new Note(NoteType.FOOTNOTE, "4", list(paragraphWithText("Hello"))); Notes notes = new Notes(list(note)); - DocumentXmlReader reader = new DocumentXmlReader(bodyReader(), notes); + DocumentXmlReader reader = new DocumentXmlReader(bodyReader(), notes, list()); XmlElement documentElement = element("w:document", list(element("w:body"))); InternalResult document = reader.readElement(documentElement); diff --git a/src/test/resources/test-data/comments.docx b/src/test/resources/test-data/comments.docx new file mode 100755 index 0000000..32cdae1 Binary files /dev/null and b/src/test/resources/test-data/comments.docx differ -- cgit v1.2.3