From 2018586035126b790223d0aa820952f123fe3e81 Mon Sep 17 00:00:00 2001 From: Nikhil Dabas Date: Fri, 18 Sep 2026 13:24:13 +0100 Subject: Fix linking failures on Windows/MSYS2 (#135) Fixes #132. My hypothesis is that the link errors were caused by `libjq` being built with the MSYS2 toolchain while the extension was linked by the mingw-w64 shipped in the runner image at `C:\mingw64`. The fix is simply to prepend the MSYS2 environment's `bin` directory to the `PATH` unconditionally. --- .github/actions/setup-msys2/action.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/actions/setup-msys2/action.yml b/.github/actions/setup-msys2/action.yml index 86093bd..35bd777 100644 --- a/.github/actions/setup-msys2/action.yml +++ b/.github/actions/setup-msys2/action.yml @@ -7,12 +7,11 @@ runs: steps: - name: Set up MSYS2 id: set-up-msys2 - uses: msys2/setup-msys2@v2.27.0 + uses: msys2/setup-msys2@v2 with: msystem: ${{ inputs.arch == 'x86' && 'mingw32' || 'ucrt64' }} install: make mingw-w64-${{ inputs.arch == 'x86' && 'i686' || 'ucrt-x86_64' }}-gcc patch - - name: Set PATH for x86 - if: ${{ inputs.arch == 'x86' }} + - name: Add MSYS2 toolchain to PATH shell: msys2 {0} - run: echo "${{ steps.set-up-msys2.outputs.msys2-location }}/mingw32/bin" >> "$GITHUB_PATH" + run: echo "${{ steps.set-up-msys2.outputs.msys2-location }}/${MSYSTEM,,}/bin" >> "$GITHUB_PATH" -- cgit v1.2.3