summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjaceyshome <jaceyshome@gmail.com>2015-05-21 21:14:15 +1000
committerjaceyshome <jaceyshome@gmail.com>2015-05-21 21:14:15 +1000
commitc608d035569e16c81ea29ecf2a904e227379cecd (patch)
treee969ba13a64710c29fc9167d5950619e0b9dacc4
parent969d80c62e7d5d5ed41a3dc7ec8f5f8bdec59a91 (diff)
styles names should be null by default
-rw-r--r--lib/docx/styles-reader.js7
-rw-r--r--tests/docx/styles-reader.tests.js11
2 files changed, 17 insertions, 1 deletions
diff --git a/lib/docx/styles-reader.js b/lib/docx/styles-reader.js
index dc90bc1..fec1cf2 100644
--- a/lib/docx/styles-reader.js
+++ b/lib/docx/styles-reader.js
@@ -36,6 +36,11 @@ function readStylesXml(xml) {
function readStyleElement(styleElement) {
var type = styleElement.attributes["w:type"];
var styleId = styleElement.attributes["w:styleId"];
- var name = styleElement.first("w:name").attributes["w:val"];
+ var name = styleName(styleElement);
return {type: type, styleId: styleId, name: name};
}
+
+function styleName(styleElement) {
+ var nameElement = styleElement.first("w:name");
+ return nameElement ? nameElement.attributes["w:val"] : null;
+}
diff --git a/tests/docx/styles-reader.tests.js b/tests/docx/styles-reader.tests.js
index 7899b1b..f76dfc2 100644
--- a/tests/docx/styles-reader.tests.js
+++ b/tests/docx/styles-reader.tests.js
@@ -59,6 +59,17 @@ describe('readStylesXml', function() {
});
assert.equal(styles.findParagraphStyleById("Heading1").name, "Heading 1");
});
+
+ test('styles names should be null by default', function() {
+ var styles = readStylesXml({
+ root: new XmlElement("w:styles", {}, [
+ paragraphStyleElement("Heading1", null),
+ characterStyleElement("Heading1Char", null)
+ ])
+ });
+ assert.equal(styles.findParagraphStyleById("Heading1Char"), null);
+ assert.equal(styles.findCharacterStyleById("Heading1"), null);
+ });
});
function paragraphStyleElement(id, name) {