From edc871d3aa33bded7ee766a7374fcdbfe93a01bd Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Sat, 27 Apr 2013 17:04:37 +0100 Subject: Use getElementsByTagName for safer image parsing --- lib/xmlreader.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) (limited to 'lib/xmlreader.js') diff --git a/lib/xmlreader.js b/lib/xmlreader.js index 08347c4..3b14a93 100644 --- a/lib/xmlreader.js +++ b/lib/xmlreader.js @@ -99,7 +99,20 @@ Element.prototype.first = function(name) { } Element.prototype.getElementsByTagName = function(name) { - return _.filter(this.children, function(child) { + var elements = _.filter(this.children, function(child) { return child.name == name; }); + return toElementList(elements); }; + +var elementListPrototype = { + getElementsByTagName: function(name) { + return toElementList(_.flatten(this.map(function(element) { + return element.getElementsByTagName(name); + }, true))); + } +}; + +function toElementList(array) { + return _.extend(array, elementListPrototype); +} -- cgit v1.2.3