From bf658f8747fbea1509ff30ca0adb374aece916cc Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Tue, 4 Oct 2016 21:58:35 +0100 Subject: Treat 0 as false in boolean elements --- tests/docx/body_xml_tests.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'tests/docx/body_xml_tests.py') diff --git a/tests/docx/body_xml_tests.py b/tests/docx/body_xml_tests.py index 3024bde..ccbd888 100644 --- a/tests/docx/body_xml_tests.py +++ b/tests/docx/body_xml_tests.py @@ -188,15 +188,25 @@ class ReadXmlElementTests(object): param(attr_name="is_strikethrough", tag_name="w:strike"), ])(istest(func)) + @run_boolean_property_test + def run_boolean_property_is_false_if_element_is_present_and_val_is_false(self, attr_name, tag_name): + run = self._read_run_with_properties([xml_element(tag_name, {"w:val": "false"})]) + assert_equal(False, getattr(run, attr_name)) + + @run_boolean_property_test + def run_boolean_property_is_false_if_element_is_present_and_val_is_0(self, attr_name, tag_name): + run = self._read_run_with_properties([xml_element(tag_name, {"w:val": "0"})]) + assert_equal(False, getattr(run, attr_name)) + @run_boolean_property_test def run_boolean_property_is_true_if_element_is_present_and_val_is_true(self, attr_name, tag_name): run = self._read_run_with_properties([xml_element(tag_name, {"w:val": "true"})]) assert_equal(True, getattr(run, attr_name)) @run_boolean_property_test - def run_boolean_property_is_false_if_element_is_present_and_val_is_false(self, attr_name, tag_name): - run = self._read_run_with_properties([xml_element(tag_name, {"w:val": "false"})]) - assert_equal(False, getattr(run, attr_name)) + def run_boolean_property_is_true_if_element_is_present_and_val_is_1(self, attr_name, tag_name): + run = self._read_run_with_properties([xml_element(tag_name, {"w:val": "1"})]) + assert_equal(True, getattr(run, attr_name)) @istest def run_has_baseline_vertical_alignment_if_vertical_alignment_element_is_not_present(self): -- cgit v1.2.3