Parse effect visibility

2 files changed, 34 insertions, 0 deletions

diff --git a/src/test/java/org/shedlang/compiler/ast/untyped/UntypedEffectDefinitionNodeMatcher.java b/src/test/java/org/shedlang/compiler/ast/untyped/UntypedEffectDefinitionNodeMatcher.java
index 33c64c7d..a0730475 100644
--- a/src/test/java/org/shedlang/compiler/ast/untyped/UntypedEffectDefinitionNodeMatcher.java
+++ b/src/test/java/org/shedlang/compiler/ast/untyped/UntypedEffectDefinitionNodeMatcher.java
@@ -2,6 +2,7 @@ package org.shedlang.compiler.ast.untyped;
 
 import org.pcollections.PVector;
 import org.shedlang.compiler.testing.MatcherBuilder;
+import org.shedlang.compiler.types.Visibility;
 import org.shedlang.compiler.util.P;
 import org.zwobble.precisely.Matcher;
 
@@ -38,4 +39,8 @@ public class UntypedEffectDefinitionNodeMatcher extends MatcherBuilder<
     public UntypedEffectDefinitionNodeMatcher withName(String name) {
         return with(has("name", x -> x.name(), equalTo(name)));
     }
+
+    public UntypedEffectDefinitionNodeMatcher withVisibility(Visibility visibility) {
+        return with(has("visibility", x -> x.visibility(), equalTo(visibility)));
+    }
 }
diff --git a/src/test/java/org/shedlang/compiler/parser/ParserEffectDefinitionTests.java b/src/test/java/org/shedlang/compiler/parser/ParserEffectDefinitionTests.java
index e697c542..6fc623ca 100644
--- a/src/test/java/org/shedlang/compiler/parser/ParserEffectDefinitionTests.java
+++ b/src/test/java/org/shedlang/compiler/parser/ParserEffectDefinitionTests.java
@@ -1,6 +1,7 @@
 package org.shedlang.compiler.parser;
 
 import org.junit.jupiter.api.Test;
+import org.shedlang.compiler.types.Visibility;
 
 import static org.shedlang.compiler.ast.untyped.UntypedNodeMatchers.isUntypedEffectDefinitionNode;
 import static org.shedlang.compiler.parser.ParserTesting.parseString;
@@ -21,4 +22,32 @@ public class ParserEffectDefinitionTests {
                 .withName("State")
         );
     }
+
+    @Test
+    public void defaultVisibilityIsPrivate() {
+        var source = """
+            effect State {
+            }""";
+
+        var node = parseString(source, Parser::parseNamespaceStatement);
+
+        assertThat(
+            node,
+            isUntypedEffectDefinitionNode().withVisibility(Visibility.PRIVATE)
+        );
+    }
+
+    @Test
+    public void whenEffectIsPrefixedWithPubThenVisibilityIsPublic() {
+        var source = """
+            pub effect State {
+            }""";
+
+        var node = parseString(source, Parser::parseNamespaceStatement);
+
+        assertThat(
+            node,
+            isUntypedEffectDefinitionNode().withVisibility(Visibility.PUBLIC)
+        );
+    }
 }