From 5bd9f3a11c73ee9c4196985a05f68f4d69ff9432 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Wed, 22 Nov 2023 22:25:40 +0000 Subject: Clarify stack references in stack IR instructions --- .../compiler/stackir/instructions/CallInstruction.java | 6 ++++-- .../stackir/instructions/DefineEffectInstruction.java | 3 ++- .../stackir/instructions/DefineFunctionInstruction.java | 3 ++- .../stackir/instructions/DefineStructInstruction.java | 3 ++- .../compiler/stackir/instructions/DiscardInstruction.java | 2 +- .../stackir/instructions/DuplicateInstruction.java | 2 +- .../stackir/instructions/FieldLoadInstruction.java | 4 ++-- .../compiler/stackir/instructions/IfInstruction.java | 9 +++++---- .../compiler/stackir/instructions/IntAddInstruction.java | 4 ++-- .../stackir/instructions/IntEqualsInstruction.java | 4 ++-- .../stackir/instructions/IntNotEqualInstruction.java | 4 ++-- .../compiler/stackir/instructions/IntSubInstruction.java | 6 +++--- .../stackir/instructions/LocalLoadInstruction.java | 3 ++- .../stackir/instructions/LocalStoreInstruction.java | 3 ++- .../instructions/NamespaceFieldStoreInstruction.java | 4 ++-- .../stackir/instructions/NamespaceImportInstruction.java | 2 +- .../stackir/instructions/PushBoolInstruction.java | 2 +- .../compiler/stackir/instructions/PushIntInstruction.java | 2 +- .../stackir/instructions/PushStringInstruction.java | 2 +- .../stackir/instructions/PushUnitInstruction.java | 2 +- .../compiler/stackir/instructions/ReturnInstruction.java | 3 ++- .../stackir/instructions/StringAddInstruction.java | 7 ++++--- .../compiler/stackir/instructions/SwitchInstruction.java | 8 ++++---- .../compiler/stackir/instructions/TryInstruction.java | 15 ++++++++------- .../stackir/instructions/TupleCreateInstruction.java | 6 +++--- .../stackir/instructions/TupleGetInstruction.java | 4 ++-- .../compiler/stackir/instructions/VarLoadInstruction.java | 2 +- .../stackir/instructions/VarStoreInstruction.java | 3 ++- 28 files changed, 65 insertions(+), 53 deletions(-) (limited to 'src/main/java') diff --git a/src/main/java/org/shedlang/compiler/stackir/instructions/CallInstruction.java b/src/main/java/org/shedlang/compiler/stackir/instructions/CallInstruction.java index 02264a62..a84c4af1 100644 --- a/src/main/java/org/shedlang/compiler/stackir/instructions/CallInstruction.java +++ b/src/main/java/org/shedlang/compiler/stackir/instructions/CallInstruction.java @@ -5,9 +5,11 @@ import org.shedlang.compiler.sources.Source; import java.util.List; /** - * Pop a receiver and arguments from the stack and call the receiver with those arguments. + * Pop a receiver and arguments from the temporary value stack and call the + * receiver with those arguments. * - *

Specifically, the values should have been pushed onto the stack in the following order:

+ *

Specifically, the values should have been pushed onto the temporary value + * stack in the following order:

* *