From 2cecc44c63d3dbbcc09cb234babde8d849fe04ac Mon Sep 17 00:00:00 2001
From: Michael Williamson <mike@zwobble.org>
Date: Wed, 25 Oct 2023 21:13:46 +0100
Subject: Add test for duplicate param names

---
 .../TypeCheckerFunctionDefinitionTests.java        | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

(limited to 'src/test/java')

diff --git a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionDefinitionTests.java b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionDefinitionTests.java
index 78b89e90..00fa8e9e 100644
--- a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionDefinitionTests.java
+++ b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionDefinitionTests.java
@@ -4,6 +4,7 @@ import org.junit.jupiter.api.Test;
 import org.shedlang.compiler.ast.untyped.Untyped;
 import org.shedlang.compiler.ast.untyped.UntypedCallNode;
 import org.shedlang.compiler.ast.untyped.UntypedFunctionDefinitionNode;
+import org.shedlang.compiler.typechecker.errors.DuplicateVariableName;
 import org.shedlang.compiler.typechecker.errors.UnexpectedTypeError;
 import org.shedlang.compiler.typechecker.typesets.TypeSets;
 import org.shedlang.compiler.types.Effects;
@@ -79,6 +80,28 @@ public class TypeCheckerFunctionDefinitionTests {
         );
     }
 
+    @Test
+    public void paramsMustHaveUniqueNames() {
+        var untyped = UntypedFunctionDefinitionNode.builder()
+            .addPositionalParam("x", Untyped.typeLevelReference("String"))
+            .addPositionalParam("x", Untyped.typeLevelReference("Int"))
+            .withReturnType(Untyped.typeLevelReference("Unit"))
+            .build();
+        var context = TypeCheckerContext.EMPTY
+            .enterGlobal(P.map(
+                Map.entry("Int", Types.metaType(Types.INT)),
+                Map.entry("String", Types.metaType(Types.STRING)),
+                Map.entry("Unit", Types.metaType(Types.UNIT))
+            ));
+
+        var error = assertThrows(
+            DuplicateVariableName.class,
+            () -> typeCheckNamespaceStatement(untyped, context)
+        );
+
+        assertThat(error.variableName(), equalTo("x"));
+    }
+
     @Test
     public void effectIsTypeChecked() {
         var untyped = UntypedFunctionDefinitionNode.builder()
-- 
cgit v1.2.3