From 6ce6049bbbfb609cb4d1acde3f4a5549aa3af9fc Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Wed, 25 Oct 2023 22:02:47 +0100 Subject: Check for duplicate named params in function type --- .../typechecker/TypeCheckerFunctionTypeTests.java | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'src/test/java') diff --git a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionTypeTests.java b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionTypeTests.java index 6b48a604..12022314 100644 --- a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionTypeTests.java +++ b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFunctionTypeTests.java @@ -3,6 +3,7 @@ package org.shedlang.compiler.typechecker; import org.junit.jupiter.api.Test; import org.shedlang.compiler.ast.untyped.Untyped; import org.shedlang.compiler.ast.untyped.UntypedFunctionTypeNode; +import org.shedlang.compiler.typechecker.errors.DuplicateVariableName; import org.shedlang.compiler.typechecker.typesets.TypeSets; import org.shedlang.compiler.types.Effects; import org.shedlang.compiler.types.FunctionType; @@ -11,6 +12,7 @@ import org.shedlang.compiler.util.P; import java.util.Map; +import static org.junit.jupiter.api.Assertions.assertThrows; import static org.shedlang.compiler.ast.typed.TypedNodeMatchers.isTypedFunctionTypeNode; import static org.zwobble.precisely.AssertThat.assertThat; import static org.zwobble.precisely.Matchers.equalTo; @@ -141,4 +143,26 @@ public class TypeCheckerFunctionTypeTests { )) ); } + + @Test + public void whenNamedParamsHaveSameNameThenErrorIsThrown() { + var untyped = UntypedFunctionTypeNode.builder() + .addNamedParam("a", Untyped.typeLevelReference("Int")) + .addNamedParam("a", Untyped.typeLevelReference("Bool")) + .withReturnType(Untyped.typeLevelReference("String")) + .build(); + var context = TypeCheckerContext.EMPTY + .enterGlobal(P.map( + Map.entry("Bool", Types.metaType(Types.BOOL)), + Map.entry("Int", Types.metaType(Types.INT)), + Map.entry("String", Types.metaType(Types.STRING)) + )); + + var error = assertThrows( + DuplicateVariableName.class, + () -> TypeChecker.typeCheckTypeLevelExpression(TypeSets.META_TYPE, untyped, context) + ); + + assertThat(error.variableName(), equalTo("a")); + } } -- cgit v1.2.3