From 906e88533789cf106f84571e8d61dbc3f55a4641 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Thu, 28 Sep 2023 11:43:44 +0100 Subject: Check type of receiver in field access --- .../typechecker/TypeCheckerFieldAccessTests.java | 28 ++++++++++++++++------ 1 file changed, 21 insertions(+), 7 deletions(-) (limited to 'src/test/java') diff --git a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFieldAccessTests.java b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFieldAccessTests.java index f560cfce..cb93f758 100644 --- a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFieldAccessTests.java +++ b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerFieldAccessTests.java @@ -2,20 +2,19 @@ package org.shedlang.compiler.typechecker; import org.junit.jupiter.api.Test; import org.shedlang.compiler.ast.untyped.Untyped; -import org.shedlang.compiler.ast.untyped.UntypedCallNode; -import org.shedlang.compiler.typechecker.errors.*; -import org.shedlang.compiler.typechecker.typesets.TypeSets; -import org.shedlang.compiler.types.*; +import org.shedlang.compiler.typechecker.errors.NoSuchFieldError; +import org.shedlang.compiler.types.NamespaceName; +import org.shedlang.compiler.types.StructTypeInfo; +import org.shedlang.compiler.types.Types; import org.shedlang.compiler.util.P; -import java.util.List; import java.util.Map; import static org.junit.jupiter.api.Assertions.assertThrows; -import static org.shedlang.compiler.ast.typed.TypedNodeMatchers.*; +import static org.shedlang.compiler.ast.typed.TypedNodeMatchers.isTypedFieldAccessNode; +import static org.shedlang.compiler.ast.typed.TypedNodeMatchers.isTypedReferenceNode; import static org.zwobble.precisely.AssertThat.assertThat; import static org.zwobble.precisely.Matchers.equalTo; -import static org.zwobble.precisely.Matchers.isSequence; public class TypeCheckerFieldAccessTests { @Test @@ -41,4 +40,19 @@ public class TypeCheckerFieldAccessTests { ) ); } + + @Test + public void whenReceiverIsNotStructTypeThenErrorIsReturned() { + var untyped = Untyped.fieldAccess( + Untyped.reference("user"), + "name" + ); + var context = TypeCheckerContext.EMPTY + .enterGlobal(P.map(Map.entry("user", Types.STRING))); + + var error = assertThrows(NoSuchFieldError.class, () -> TypeChecker.typeCheckExpression(untyped, context)); + + assertThat(error.type(), equalTo(Types.STRING)); + assertThat(error.fieldName(), equalTo("name")); + } } -- cgit v1.2.3