From bf1707367f6c26ced547c3504f267a2c7ca275a4 Mon Sep 17 00:00:00 2001 From: Michael Williamson Date: Sat, 10 Jun 2023 11:32:29 +0100 Subject: Check all named args have been passed --- .../compiler/typechecker/TypeCheckerCallTests.java | 49 +++++++++++++++++++++- 1 file changed, 47 insertions(+), 2 deletions(-) (limited to 'src/test/java') diff --git a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerCallTests.java b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerCallTests.java index d8977b43..c46587c3 100644 --- a/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerCallTests.java +++ b/src/test/java/org/shedlang/compiler/typechecker/TypeCheckerCallTests.java @@ -2,8 +2,10 @@ package org.shedlang.compiler.typechecker; import org.junit.jupiter.api.Test; import org.shedlang.compiler.ast.untyped.Untyped; +import org.shedlang.compiler.typechecker.errors.MissingNamedArgError; +import org.shedlang.compiler.typechecker.errors.UnexpectedNamedArgError; import org.shedlang.compiler.typechecker.errors.UnexpectedTypeError; -import org.shedlang.compiler.typechecker.errors.WrongNumberOfPositionalArgs; +import org.shedlang.compiler.typechecker.errors.WrongNumberOfPositionalArgsError; import org.shedlang.compiler.typechecker.typesets.TypeSets; import org.shedlang.compiler.types.FunctionType; import org.shedlang.compiler.types.Types; @@ -179,11 +181,54 @@ public class TypeCheckerCallTests { .enter(P.map(Map.entry("f", functionType))); var error = assertThrows( - WrongNumberOfPositionalArgs.class, + WrongNumberOfPositionalArgsError.class, () -> TypeChecker.typeCheckExpression(untyped, context) ); assertThat(error.expected(), equalTo(0)); assertThat(error.actual(), equalTo(1)); } + + @Test + public void whenNamedArgumentIsMissingThenErrorIsThrown() { + var untyped = Untyped.call( + Untyped.reference("f"), + List.of(), + List.of() + ); + var functionType = FunctionType.builder() + .addNamedParam("x", Types.STRING) + .build(); + var context = TypeCheckerContext.EMPTY + .enter(P.map(Map.entry("f", functionType))); + + var error = assertThrows( + MissingNamedArgError.class, + () -> TypeChecker.typeCheckExpression(untyped, context) + ); + + assertThat(error.argName(), equalTo("x")); + } + + @Test + public void whenExtraNamedArgumentIsPassedThenErrorIsThrown() { + var untyped = Untyped.call( + Untyped.reference("f"), + List.of(), + List.of( + Untyped.namedArg("x", Untyped.stringLiteral("hello")) + ) + ); + var functionType = FunctionType.builder() + .build(); + var context = TypeCheckerContext.EMPTY + .enter(P.map(Map.entry("f", functionType))); + + var error = assertThrows( + UnexpectedNamedArgError.class, + () -> TypeChecker.typeCheckExpression(untyped, context) + ); + + assertThat(error.argName(), equalTo("x")); + } } -- cgit v1.2.3