From c472034dcdea19ac4e25202ecf76d7ad4a2616b4 Mon Sep 17 00:00:00 2001
From: Michael Williamson <mike@zwobble.org>
Date: Wed, 20 Dec 2023 19:01:38 +0000
Subject: Only include cyclic dependencies in error

---
 .../NamespaceDependencyLineariserTests.java        | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

(limited to 'src/test/java')

diff --git a/src/test/java/org/shedlang/compiler/typechecker/NamespaceDependencyLineariserTests.java b/src/test/java/org/shedlang/compiler/typechecker/NamespaceDependencyLineariserTests.java
index 0a8e72bc..fba6d0e4 100644
--- a/src/test/java/org/shedlang/compiler/typechecker/NamespaceDependencyLineariserTests.java
+++ b/src/test/java/org/shedlang/compiler/typechecker/NamespaceDependencyLineariserTests.java
@@ -136,6 +136,28 @@ public class NamespaceDependencyLineariserTests {
         ));
     }
 
+    @Test
+    public void cycleOfDependenciesDoesNotIncludeParentDependenciesOutsideOfCycle() {
+        var namespaces = List.of(
+            namespaceNode("Z", List.of("A")),
+            namespaceNode("A", List.of("B")),
+            namespaceNode("B", List.of("C")),
+            namespaceNode("C", List.of("A"))
+        );
+
+        var error = assertThrows(
+            CircularNamespaceDependencyError.class,
+            () -> NamespaceDependencyLineariser.orderNamespaces(namespaces)
+        );
+
+        assertThat(error.namespaceNames(), isSequence(
+            equalTo(NamespaceName.of("A")),
+            equalTo(NamespaceName.of("B")),
+            equalTo(NamespaceName.of("C")),
+            equalTo(NamespaceName.of("A"))
+        ));
+    }
+
     private static UntypedNamespaceNode namespaceNode(
         String namespaceName,
         List<String> dependencies
-- 
cgit v1.2.3