aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Williamson <mike@zwobble.org>2015-10-06 17:41:14 +0100
committerMichael Williamson <mike@zwobble.org>2015-10-06 17:41:14 +0100
commit0c12bb7771537380a22083a8d0dd6df46a95bb99 (patch)
tree50b8e1d497e6617b97396541683d9856d6c3738d
parent51a35969d3b4a165e94532d3cc3e522a63b2c56f (diff)
Throw error if field is unbound
-rw-r--r--src/main/java/org/zwobble/couscous/interpreter/UnboundField.java12
-rw-r--r--src/main/java/org/zwobble/couscous/interpreter/values/ObjectInterpreterValue.java4
-rw-r--r--src/test/java/org/zwobble/couscous/tests/interpreter/EvaluatorTests.java20
3 files changed, 35 insertions, 1 deletions
diff --git a/src/main/java/org/zwobble/couscous/interpreter/UnboundField.java b/src/main/java/org/zwobble/couscous/interpreter/UnboundField.java
new file mode 100644
index 0000000..2efca06
--- /dev/null
+++ b/src/main/java/org/zwobble/couscous/interpreter/UnboundField.java
@@ -0,0 +1,12 @@
+package org.zwobble.couscous.interpreter;
+
+import lombok.EqualsAndHashCode;
+import lombok.Value;
+
+@Value
+@EqualsAndHashCode(callSuper=false)
+public class UnboundField extends InterpreterException {
+ private static final long serialVersionUID = 1L;
+
+ String fieldName;
+}
diff --git a/src/main/java/org/zwobble/couscous/interpreter/values/ObjectInterpreterValue.java b/src/main/java/org/zwobble/couscous/interpreter/values/ObjectInterpreterValue.java
index b6a1e87..03e8061 100644
--- a/src/main/java/org/zwobble/couscous/interpreter/values/ObjectInterpreterValue.java
+++ b/src/main/java/org/zwobble/couscous/interpreter/values/ObjectInterpreterValue.java
@@ -6,6 +6,7 @@ import java.util.Optional;
import org.zwobble.couscous.interpreter.InterpreterTypes;
import org.zwobble.couscous.interpreter.NoSuchField;
+import org.zwobble.couscous.interpreter.UnboundField;
import org.zwobble.couscous.values.PrimitiveValue;
import lombok.val;
@@ -31,10 +32,11 @@ public class ObjectInterpreterValue implements InterpreterValue {
@Override
public InterpreterValue getField(String fieldName) {
+ type.getField(fieldName).orElseThrow(() -> new NoSuchField(fieldName));
if (fields.containsKey(fieldName)) {
return fields.get(fieldName);
} else {
- throw new NoSuchField(fieldName);
+ throw new UnboundField(fieldName);
}
}
diff --git a/src/test/java/org/zwobble/couscous/tests/interpreter/EvaluatorTests.java b/src/test/java/org/zwobble/couscous/tests/interpreter/EvaluatorTests.java
index 0f96fe7..e8875ae 100644
--- a/src/test/java/org/zwobble/couscous/tests/interpreter/EvaluatorTests.java
+++ b/src/test/java/org/zwobble/couscous/tests/interpreter/EvaluatorTests.java
@@ -14,6 +14,7 @@ import org.zwobble.couscous.interpreter.Environment;
import org.zwobble.couscous.interpreter.NoSuchField;
import org.zwobble.couscous.interpreter.NoSuchMethod;
import org.zwobble.couscous.interpreter.StackFrameBuilder;
+import org.zwobble.couscous.interpreter.UnboundField;
import org.zwobble.couscous.interpreter.UnexpectedValueType;
import org.zwobble.couscous.interpreter.WrongNumberOfArguments;
import org.zwobble.couscous.interpreter.values.IntegerInterpreterValue;
@@ -134,6 +135,25 @@ public class EvaluatorTests extends BackendEvalTests {
}
@Test
+ public void cannotGetValueOfUnbounddField() {
+ val classNode = ClassNode.builder("com.example.Example")
+ .field("value", IntegerValue.REF)
+ .build();
+
+ val exception = assertThrows(UnboundField.class,
+ () -> evalExpression(
+ asList(classNode),
+ fieldAccess(
+ constructorCall(
+ classNode.getName(),
+ asList()),
+ "value",
+ IntegerValue.REF)));
+
+ assertEquals(new UnboundField("value"), exception);
+ }
+
+ @Test
public void cannotSetValueOfUndeclaredField() {
val classNode = ClassNode.builder("com.example.Example")
.constructor(constructor -> constructor