Ignore v:imagedata elements without relationship ID with warning

1 files changed, 7 insertions, 4 deletions

diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java
index 5f93c4a..e4c5b5f 100644
--- a/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java
+++ b/src/main/java/org/zwobble/mammoth/internal/docx/BodyXmlReader.java
@@ -381,10 +381,13 @@ public class BodyXmlReader {
     }
 
     private ReadResult readImagedata(XmlElement element) {
-        Optional<String> title = element.getAttributeOrNone("o:title");
-        String relationshipId = element.getAttribute("r:id");
-        String imagePath = relationshipIdToDocxPath(relationshipId);
-        return readImage(imagePath, title, () -> DocxFiles.getInputStream(file, imagePath));
+        return element.getAttributeOrNone("r:id")
+            .map(relationshipId -> {
+                Optional<String> title = element.getAttributeOrNone("o:title");
+                String imagePath = relationshipIdToDocxPath(relationshipId);
+                return readImage(imagePath, title, () -> DocxFiles.getInputStream(file, imagePath));
+            })
+            .orElse(ReadResult.emptyWithWarning("A v:imagedata element without a relationship ID was ignored"));
     }
 
     private ReadResult readInline(XmlElement element) {