diff options
| author | Michael Williamson <mike@zwobble.org> | 2021-11-01 19:40:11 +0000 |
|---|---|---|
| committer | Michael Williamson <mike@zwobble.org> | 2021-11-01 19:40:11 +0000 |
| commit | 101c77ddd649ec925999c43dee91e65cdeb98d79 (patch) | |
| tree | de606b74b14407e0edd6a46e21828e92d3b8f53f /src | |
| parent | fc264c2431ed91a33674e3b36d596c2eb28185ad (diff) | |
Handle a:blip elements without image file
Diffstat (limited to 'src')
| -rw-r--r-- | src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java | 3 | ||||
| -rw-r--r-- | src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java | 12 |
2 files changed, 13 insertions, 2 deletions
diff --git a/src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java b/src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java index b6bd51e..de4a73b 100644 --- a/src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java +++ b/src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java @@ -613,8 +613,7 @@ class StatefulBodyXmlReader { String imagePath = relationships.findTargetByRelationshipId(linkRelationshipId.get()); return readImage(imagePath, altText, () -> fileReader.getInputStream(imagePath)); } else { - // TODO: emit warning - return ReadResult.EMPTY_SUCCESS; + return ReadResult.emptyWithWarning("Could not find image file for a:blip element"); } } diff --git a/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java b/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java index a3d315d..cff4338 100644 --- a/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java +++ b/src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java @@ -1379,6 +1379,18 @@ public class BodyXmlTests { } @Test + public void warningIfBlipHasNoImageFile() { + XmlElement element = inlineImageXml(element("a:blip"), ""); + + InternalResult<?> result = readAll(bodyReader(), element); + + assertThat(result, isInternalResult( + equalTo(list()), + list("Could not find image file for a:blip element") + )); + } + + @Test public void warningIfImageTypeIsUnsupportedByWebBrowsers() { XmlElement element = inlineImageXml(embeddedBlipXml(IMAGE_RELATIONSHIP_ID), ""); Relationships relationships = new Relationships(list( |
