aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMichael Williamson <mike@zwobble.org>2016-06-28 21:51:50 +0100
committerMichael Williamson <mike@zwobble.org>2016-06-28 21:51:50 +0100
commit4b13398d9f4fc303d22fc24aac519113941b032c (patch)
tree7422aa51b30de16ff9a90fb8863f1503ef755642 /lib
parentd046c4297a04b6eecadf01093382b72bb1b71032 (diff)
Add stylistic eslint rules
Diffstat (limited to 'lib')
-rw-r--r--lib/docx/body-reader.js9
-rw-r--r--lib/docx/docx-reader.js2
-rw-r--r--lib/style-reader.js2
-rw-r--r--lib/writers/markdown-writer.js4
-rw-r--r--lib/xml/nodes.js4
-rw-r--r--lib/xml/reader.js4
6 files changed, 15 insertions, 10 deletions
diff --git a/lib/docx/body-reader.js b/lib/docx/body-reader.js
index 71ad29d..c338893 100644
--- a/lib/docx/body-reader.js
+++ b/lib/docx/body-reader.js
@@ -232,7 +232,7 @@ function BodyReader(options) {
var properties = element.firstOrEmpty("w:tcPr");
var gridSpan = properties.firstOrEmpty("w:gridSpan").attributes["w:val"];
- var colSpan = gridSpan ? parseInt(gridSpan) : 1;
+ var colSpan = gridSpan ? parseInt(gridSpan, 10) : 1;
var cell = documents.TableCell(children, {colSpan: colSpan});
cell._vMerge = readVMerge(properties);
@@ -408,7 +408,6 @@ function joinZipPath(first, second) {
}
-
function emptyResultWithMessages(messages) {
return new ReadResult(null, null, messages);
}
@@ -466,7 +465,7 @@ function combineResults(results) {
var result = Result.combine(_.pluck(results, "_result"));
return new ReadResult(
_.flatten(_.pluck(result.value, "element")),
- _.filter(_.flatten(_.pluck(result.value, "extra")), function(x) { return x; }),
+ _.filter(_.flatten(_.pluck(result.value, "extra")), identity),
result.messages
);
}
@@ -474,3 +473,7 @@ function combineResults(results) {
function joinElements(first, second) {
return _.flatten([first, second]);
}
+
+function identity(value) {
+ return value;
+}
diff --git a/lib/docx/docx-reader.js b/lib/docx/docx-reader.js
index 8ef4960..6ad63ab 100644
--- a/lib/docx/docx-reader.js
+++ b/lib/docx/docx-reader.js
@@ -57,7 +57,7 @@ function read(docxFile, input) {
bodyReader: bodyReader,
notes: notes
});
- return reader.convertXmlToDocument(xml);
+ return reader.convertXmlToDocument(xml);
});
});
});
diff --git a/lib/style-reader.js b/lib/style-reader.js
index 9969bbe..b5fb8ce 100644
--- a/lib/style-reader.js
+++ b/lib/style-reader.js
@@ -126,7 +126,7 @@ function documentMatcherRule() {
var underline = identifierToConstant("u", documentMatchers.underline);
var strikethrough = identifierToConstant("strike", documentMatchers.strikethrough);
- return lop.rules.firstOf("element type",
+ return lop.rules.firstOf("element type",
paragraphOrRun,
bold,
italic,
diff --git a/lib/writers/markdown-writer.js b/lib/writers/markdown-writer.js
index 079d924..4284532 100644
--- a/lib/writers/markdown-writer.js
+++ b/lib/writers/markdown-writer.js
@@ -98,7 +98,9 @@ function markdownWriter() {
function open(tagName, attributes) {
attributes = attributes || {};
- var createElement = htmlToMarkdown[tagName] || function() { return {}; };
+ var createElement = htmlToMarkdown[tagName] || function() {
+ return {};
+ };
var element = createElement(attributes, list, listItem);
elementStack.push({end: element.end, list: list});
diff --git a/lib/xml/nodes.js b/lib/xml/nodes.js
index 9305918..76f5fd7 100644
--- a/lib/xml/nodes.js
+++ b/lib/xml/nodes.js
@@ -32,7 +32,7 @@ function Element(name, attributes, children) {
Element.prototype.first = function(name) {
return _.find(this.children, function(child) {
- return child.name == name;
+ return child.name === name;
});
};
@@ -42,7 +42,7 @@ Element.prototype.firstOrEmpty = function(name) {
Element.prototype.getElementsByTagName = function(name) {
var elements = _.filter(this.children, function(child) {
- return child.name == name;
+ return child.name === name;
});
return toElementList(elements);
};
diff --git a/lib/xml/reader.js b/lib/xml/reader.js
index 67b69be..844ee0c 100644
--- a/lib/xml/reader.js
+++ b/lib/xml/reader.js
@@ -78,8 +78,8 @@ function readString(xmlString, namespaceMap) {
function mapObject(input, valueFunc, keyFunc) {
return _.reduce(input, function(result, value, key) {
- var mappedKey = keyFunc.call(null, value, key, input);
- result[mappedKey] = valueFunc.call(null, value, key, input);
+ var mappedKey = keyFunc(value, key, input);
+ result[mappedKey] = valueFunc(value, key, input);
return result;
}, {});
}